--- freem/src/mumps.c 2025/04/10 01:24:38 1.19 +++ freem/src/mumps.c 2025/04/13 04:22:43 1.20 @@ -1,5 +1,5 @@ /* - * $Id: mumps.c,v 1.19 2025/04/10 01:24:38 snw Exp $ + * $Id: mumps.c,v 1.20 2025/04/13 04:22:43 snw Exp $ * main module of freem * * @@ -24,6 +24,9 @@ * along with FreeM. If not, see . * * $Log: mumps.c,v $ + * Revision 1.20 2025/04/13 04:22:43 snw + * Fix snprintf calls + * * Revision 1.19 2025/04/10 01:24:38 snw * Remove C++ style comments * @@ -459,8 +462,8 @@ int main (int argc, char **argv, char ** } #endif - snprintf (config_file, 4096, "%s/freem/%s/freem.conf", SYSCONFDIR, shm_env); - snprintf (env_config_file, 4096, "%s/freem/env.conf", SYSCONFDIR); + snprintf (config_file, sizeof (config_file) - 1, "%s/freem/%s/freem.conf", SYSCONFDIR, shm_env); + snprintf (env_config_file, sizeof (config_file) - 1, "%s/freem/env.conf", SYSCONFDIR); if (!file_exists (env_config_file)) { fprintf (stderr, "freem: environment catalog does not exist; may need to run fmadm configure\n"); @@ -725,20 +728,20 @@ int main (int argc, char **argv, char ** } /* make this the startup routine */ - snprintf (startuprou, 256, "^%s\201", cli_rtn_name); + snprintf (startuprou, sizeof (startuprou) - 1, "^%s\201", cli_rtn_name); /* re-work the namespace config to search for the routine in the discovered path */ if (cli_rtn_name[0] == '%') { - snprintf (rou0plib, 256, "%s\201", cli_rtn_path); - snprintf (rou1plib, 256, "%s\201", cli_rtn_path); + snprintf (rou0plib, sizeof (rou0plib) - 1, "%s\201", cli_rtn_path); + snprintf (rou1plib, sizeof (rou1plib) - 1, "%s\201", cli_rtn_path); } else { - snprintf (rou0path, 256, "%s\201", cli_rtn_path); - snprintf (rou1path, 256, "%s\201", cli_rtn_path); + snprintf (rou0path, sizeof (rou0path) - 1, "%s\201", cli_rtn_path); + snprintf (rou1path, sizeof (rou1path) - 1, "%s\201", cli_rtn_path); } @@ -894,10 +897,10 @@ int main (int argc, char **argv, char ** stcpy (verstr, FREEM_VERSION_STR); stcnv_m2c (verstr); - snprintf (version, 255, "\r\nCoherent Logic Development FreeM version %s [DIALECT: %s%s]\r\n\201", verstr, m_dialect, (restricted_mode == TRUE ? "/RESTRICTED" : "")); + snprintf (version, sizeof (version) - 1, "\r\nCoherent Logic Development FreeM version %s [DIALECT: %s%s]\r\n\201", verstr, m_dialect, (restricted_mode == TRUE ? "/RESTRICTED" : "")); write_m (version); - snprintf (version, 255, "Copyright (C) 2014, 2020, 2021, 2023, 2025 Coherent Logic Development LLC\r\n\r\n\201"); + snprintf (version, sizeof (version) - 1, "Copyright (C) 2014, 2020, 2021, 2023, 2025 Coherent Logic Development LLC\r\n\r\n\201"); write_m (version); /* @@ -914,7 +917,7 @@ int main (int argc, char **argv, char ** if (dx_mode) { char k_buf[512]; - snprintf (k_buf, 512 - 1, "%%TMPINITMCODE\201\201"); + snprintf (k_buf, sizeof (k_buf) - 1, "%%TMPINITMCODE\201\201"); symtab (set_sym, k_buf, dx_mcode); const_define (k_buf, dx_mcode); } @@ -922,7 +925,7 @@ int main (int argc, char **argv, char ** if (routine_mode) { char k_buf[512]; - snprintf (k_buf, 512 - 1, "%%TMPINITROUTINE\201\201"); + snprintf (k_buf, sizeof (k_buf) - 1, "%%TMPINITROUTINE\201\201"); symtab (set_sym, k_buf, startup_routine); const_define (k_buf, startup_routine); }