--- freem/src/strings.c 2025/03/09 19:50:47 1.3 +++ freem/src/strings.c 2025/04/13 04:22:43 1.6 @@ -1,5 +1,5 @@ /* - * $Id: strings.c,v 1.3 2025/03/09 19:50:47 snw Exp $ + * $Id: strings.c,v 1.6 2025/04/13 04:22:43 snw Exp $ * freem string library * * @@ -24,6 +24,15 @@ * along with FreeM. If not, see . * * $Log: strings.c,v $ + * Revision 1.6 2025/04/13 04:22:43 snw + * Fix snprintf calls + * + * Revision 1.5 2025/04/10 01:24:39 snw + * Remove C++ style comments + * + * Revision 1.4 2025/04/09 19:52:02 snw + * Eliminate as many warnings as possible while building with -Wall + * * Revision 1.3 2025/03/09 19:50:47 snw * Second phase of REUSE compliance and header reformat * @@ -57,7 +66,6 @@ long int stnlen (const char *source, siz return length; } - /* copy string from 'source' to 'dest' */ long int stcpy (char *dest, const char *source) { @@ -108,7 +116,6 @@ short int stcat (char *dest, const char while ((dest[i] = *source++) != EOL) { if (i++ >= STRLEN) { - //printf("i = %d\r\n", i); dest[--i] = EOL; return FALSE; } @@ -118,18 +125,6 @@ short int stcat (char *dest, const char return TRUE; } -long int stncat (char *dest, const char *source, size_t siz) -{ - long int srclen; - long int dstlen; - - srclen = stnlen (source, siz); - dstlen = stnlen (dest, siz); - - - return 0; -} - /* compare str1 and str2 */ short int stcmp (char *str1, char *str2) { @@ -225,6 +220,7 @@ void stncnv_c2m(char *cstr, size_t siz) return; } + /* convert at most 'count' characters of *key into human-readable format in *buf */ size_t key_to_name(char *buf, const char *key, size_t count) { @@ -249,7 +245,7 @@ size_t key_to_name(char *buf, const char c = key[i]; next = key[i + 1]; - switch (key[i]) { + switch (c) { case EOL: @@ -485,8 +481,8 @@ void uuid_v4 (char *buf) seg2[4] = '\0'; - snprintf (seg3, 5, "%04x", seg3num); - snprintf (seg4, 5, "%04x", seg4num); + snprintf (seg3, sizeof (seg3), "%04x", seg3num); + snprintf (seg4, sizeof (seg4), "%04x", seg4num); for (i = 0; i < 12; i++) { seg5[i] = chars[rand () % 16];