[BACK]Return to shmmgr.c CVS log [TXT] [DIR] Up to [Coherent Logic Development] / freem / src

Diff for /freem/src/shmmgr.c between versions 1.7 and 1.12

version 1.7, 2025/04/09 19:52:02 version 1.12, 2025/04/15 21:57:10
Line 24 Line 24
  *   along with FreeM.  If not, see <https://www.gnu.org/licenses/>.   *   along with FreeM.  If not, see <https://www.gnu.org/licenses/>.
  *   *
  *   $Log$   *   $Log$
    *   Revision 1.12  2025/04/15 21:57:10  snw
    *   Fix SysV IPC bugs on FreeBSD
    *
    *   Revision 1.11  2025/04/15 21:08:51  snw
    *   Add some useful debug output
    *
    *   Revision 1.10  2025/04/15 19:26:13  snw
    *   Remove extra whitespace
    *
    *   Revision 1.9  2025/04/15 16:49:36  snw
    *   Make use of logprintf throughout codebase
    *
    *   Revision 1.8  2025/04/14 19:46:18  snw
    *   Add SHM_REMAP flag to shmat on FreeBSD
    *
  *   Revision 1.7  2025/04/09 19:52:02  snw   *   Revision 1.7  2025/04/09 19:52:02  snw
  *   Eliminate as many warnings as possible while building with -Wall   *   Eliminate as many warnings as possible while building with -Wall
  *   *
Line 52 Line 67
 #include "shmmgr.h"  #include "shmmgr.h"
 #include "mpsdef.h"  #include "mpsdef.h"
 #include "locktab.h"  #include "locktab.h"
   #include "log.h"
   
 #include <sys/types.h>  #include <sys/types.h>
 #include <sys/ipc.h>  #include <sys/ipc.h>
Line 77  void shm_daemon_init(void); Line 93  void shm_daemon_init(void);
   
 shm_config_t *shm_config = (shm_config_t *) NULL;  shm_config_t *shm_config = (shm_config_t *) NULL;
   
   #if defined(__FreeBSD__)
   # define FM_SHM_PERMS 0660
   #else
   # define FM_SHM_PERMS 0770
   #endif
   
 short shm_init(const size_t seg_size)  short shm_init(const size_t seg_size)
 {  {
     size_t alloc_map_size;      size_t alloc_map_size;
Line 98  short shm_init(const size_t seg_size) Line 120  short shm_init(const size_t seg_size)
     shm_config->segsiz = seg_size + alloc_map_size + pg_size;      shm_config->segsiz = seg_size + alloc_map_size + pg_size;
     shm_config->key = ftok (config_file, 1);      shm_config->key = ftok (config_file, 1);
     shm_config->pgsiz = pg_size;      shm_config->pgsiz = pg_size;
              
     shm_config->seg_id = shmget (shm_config->key, shm_config->segsiz, 0770 | IPC_CREAT);      shm_config->seg_id = shmget (shm_config->key, shm_config->segsiz, FM_SHM_PERMS | IPC_CREAT);
     if (shm_config->seg_id == -1) {      if (shm_config->seg_id == -1) {
         if (errno == 22) {          if (errno == 22) {
             fprintf (stderr, "shm_init:  cannot get shared memory segment of %ld bytes\r\n\r\n", (unsigned long) shm_config->segsiz);              logprintf (FM_LOG_ERROR, "shm_init:  cannot get shared memory segment of %ld bytes", (unsigned long) shm_config->segsiz);
             fprintf (stderr, "You may need to tune your kernel parameters, or manually set a smaller shared memory segment size in both the FreeM daemon and each interpreter process by using the `-S` command-line flag.\r\n\r\nPlease refer to the FreeM Platform Notes for your operating system for details.\r\n\r\n");               fprintf (stderr, "\r\nYou may need to tune your kernel parameters, or manually set a smaller shared memory segment size in both the FreeM daemon and each interpreter process by using the `-S` command-line flag.\r\n\r\nPlease refer to the FreeM Platform Notes for your operating system for details.\r\n"); 
         }          }
         return SHMS_GET_ERR;          return SHMS_GET_ERR;
     }      }
Line 138  short shm_init(const size_t seg_size) Line 160  short shm_init(const size_t seg_size)
   
         if (daemon_chk == -1 && errno == ESRCH) {          if (daemon_chk == -1 && errno == ESRCH) {
   
             fprintf (stderr, "shm_init:  recovering from crashed daemon pid %d\r\n", shm_config->hdr->first_process);              logprintf (FM_LOG_WARNING, "shm_init:  recovering from crashed daemon pid %ld", shm_config->hdr->first_process);
   
             first_process = TRUE;              first_process = TRUE;
   
Line 152  short shm_init(const size_t seg_size) Line 174  short shm_init(const size_t seg_size)
   
             semid_shm = semget (shm_sk, 1, 0);              semid_shm = semget (shm_sk, 1, 0);
             if (semid_shm == -1) {              if (semid_shm == -1) {
                 fprintf (stderr, "shm_init:  could not attach to shared memory semaphore\r\n");                  logprintf (FM_LOG_FATAL, "shm_init:  could not attach to shared memory semaphore [%s]", strerror (errno));         
                 exit (1);  
             }              }
                           
             /* we are NOT the initial process. if addresses don't match, re-attach! */              /* we are NOT the initial process. if addresses don't match, re-attach! */
Line 163  short shm_init(const size_t seg_size) Line 184  short shm_init(const size_t seg_size)
                 /* grab the pointers we need */                  /* grab the pointers we need */
                 void *old_addr = shm_config->dta;                  void *old_addr = shm_config->dta;
                 void *new_addr = shm_config->hdr->shmad;                  void *new_addr = shm_config->hdr->shmad;
   
                   logprintf (FM_LOG_INFO, "shmmgr:  remapping shared memory from virtual address %p to %p", old_addr, new_addr);
                                   
                 /* detach and reattach */                  /* detach and reattach */
                 if (shmdt (old_addr) == -1) {                  if (shmdt (old_addr) == -1) {
                     fprintf (stderr, "shm_init:  detach failed during detach/reattach [shmdt error %s]\r\n", strerror (errno));                      logprintf (FM_LOG_FATAL, "shm_init:  detach failed during detach/reattach [shmdt error %s]", strerror (errno));
                     exit (1);  
                 }                  }
                   
                 shm_config->dta = shmat (shm_config->seg_id, new_addr, 0);                  shm_config->dta = shmat (shm_config->seg_id, new_addr, 0);
   
                 if (shm_config->dta == (void *) -1) {                  if (shm_config->dta == (void *) -1) {
                     fprintf (stderr, "shm_init:  fatal error attaching shared memory segment [shmat error '%s']\r\n", strerror (errno));                      logprintf (FM_LOG_FATAL, "shm_init:  fatal error attaching shared memory segment [shmat error '%s']", strerror (errno));
                     exit (1);  
                 }                  }
                                   
                 shm_config->hdr = (shm_hdr_t *) shm_config->dta;                  shm_config->hdr = (shm_hdr_t *) shm_config->dta;
Line 208  void shm_daemon_init(void) Line 229  void shm_daemon_init(void)
           
     semid_shm = semget (shm_sk, 1, 0660 | IPC_CREAT);      semid_shm = semget (shm_sk, 1, 0660 | IPC_CREAT);
     if (semid_shm == -1) {      if (semid_shm == -1) {
         fprintf (stderr, "shm_init:  failed to create shared memory semaphore\r\n");          logprintf (FM_LOG_FATAL, "shm_init:  failed to create shared memory semaphore [%s]", strerror (errno));
         exit (1);  
     }      }
           
     arg.val = 1;      arg.val = 1;
     if (semctl (semid_shm, 0, SETVAL, arg) == -1) {      if (semctl (semid_shm, 0, SETVAL, arg) == -1) {
         fprintf (stderr, "shm_init:  failed to initialize shared memory semaphore\r\n");          logprintf (FM_LOG_FATAL, "shm_init:  failed to initialize shared memory semaphore [%s]", strerror (errno));  
         exit (1);  
     }      }
           
     /* zero out the segment */      /* zero out the segment */
Line 234  void shm_daemon_init(void) Line 253  void shm_daemon_init(void)
     shm_config->alloc_map = (shm_page_t *) (shm_config->dta + sizeof (shm_hdr_t));      shm_config->alloc_map = (shm_page_t *) (shm_config->dta + sizeof (shm_hdr_t));
 */      */    
     shm_config->buf = SHMALIGN(shm_config->dta + (sizeof (shm_hdr_t) * shm_config->pgct));      shm_config->buf = SHMALIGN(shm_config->dta + (sizeof (shm_hdr_t) * shm_config->pgct));
     printf ("shm_daemon_init:  allocator buffer aligned at %p (system page size %ld)\r\n", shm_config->buf, sysconf (_SC_PAGESIZE));      logprintf (FM_LOG_INFO, "shm_daemon_init:  allocator buffer aligned at %p (system page size %ld)", shm_config->buf, sysconf (_SC_PAGESIZE));
           
     for (i = 0; i < shm_config->pgct; i++) {      for (i = 0; i < shm_config->pgct; i++) {
         shm_config->hdr->alloc_map[i].is_first = FALSE;          shm_config->hdr->alloc_map[i].is_first = FALSE;
Line 252  short shm_exit(void) Line 271  short shm_exit(void)
     res = shmdt (shm_config->dta);      res = shmdt (shm_config->dta);
   
     if (res == -1) {      if (res == -1) {
         fprintf (stderr, "shm_exit:  failure in shmdt()\r\n");          logprintf (FM_LOG_ERROR, "shm_exit:  failure in shmdt() [%s]", strerror (errno));
         return FALSE;          return FALSE;
     }      }
           
Line 261  short shm_exit(void) Line 280  short shm_exit(void)
         res = shmctl (shm_config->seg_id, IPC_RMID, 0);          res = shmctl (shm_config->seg_id, IPC_RMID, 0);
   
         if (res == -1) {          if (res == -1) {
             fprintf (stderr, "shm_exit:  failure in shmctl()\r\n");              logprintf (FM_LOG_ERROR, "shm_exit:  failure in shmctl() [%s]", strerror (errno));
             return FALSE;              return FALSE;
         }          }
   
Line 347  void *shm_alloc_pages(const int page_cou Line 366  void *shm_alloc_pages(const int page_cou
     shm_page_t *pg;      shm_page_t *pg;
   
     if (shm_get_sem () == FALSE) {      if (shm_get_sem () == FALSE) {
         fprintf (stderr, "shm_alloc_pages:  could not get exclusive access to shared memory\r\n");          logprintf (FM_LOG_FATAL, "shm_alloc_pages:  could not get exclusive access to shared memory");
         exit (1);  
     }      }
   
           
Line 423  void shm_free_page(const int page_number Line 441  void shm_free_page(const int page_number
     shm_page_t *a = shm_get_alloc_map_entry (page_number);      shm_page_t *a = shm_get_alloc_map_entry (page_number);
   
     if (a->is_first == FALSE) {      if (a->is_first == FALSE) {
         fprintf (stderr, "shm_free_page:  attempt to free page in the middle of allocation chain\r\n");          logprintf (FM_LOG_ERROR, "shm_free_page:  attempt to free page in the middle of allocation chain");
         return;          return;
     }      }
   
     if (a->pg_state == PG_FREE) {      if (a->pg_state == PG_FREE) {
         fprintf (stderr, "shm_free_page:  double free attempted in page %d\r\n", page_number);          logprintf (FM_LOG_FATAL, "shm_free_page:  double free attempted in page %d", page_number);
         exit (1);  
     }      }
           
     if (shm_get_sem () == FALSE) {      if (shm_get_sem () == FALSE) {
         fprintf (stderr, "shm_free_page:  could not get exclusive access to shared memory\r\n");          logprintf (FM_LOG_FATAL, "shm_free_page:  could not get exclusive access to shared memory");
         exit (1);  
     }      }
   
           
Removed from v.1.7  
changed lines
  Added in v.1.12

FreeBSD-CVSweb <freebsd-cvsweb@FreeBSD.org>